-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cryptopp] clang-cl: fix compilation with cryptopp/gzip.h #40679
Merged
vicroms
merged 6 commits into
microsoft:master
from
globusmedical:feature/cryptopp-8.9.0_1
Sep 8, 2024
Merged
[cryptopp] clang-cl: fix compilation with cryptopp/gzip.h #40679
vicroms
merged 6 commits into
microsoft:master
from
globusmedical:feature/cryptopp-8.9.0_1
Sep 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/// have to provide a template class member called rebind". | ||
template <class V> struct rebind { typedef AllocatorWithCleanup<V, T_Align16> other; }; | ||
-#if (CRYPTOPP_MSC_VERSION >= 1500) | ||
+#if (CRYPTOPP_MSC_VERSION >= 1500) || defined(__clang__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This is the fix for the issue I have found compiling my project with ClangCL when I include
cryptocc/gzip.h
. - The patch file has been taken from the comments on this issue: [cryptopp] build failure using clang-cl (Windows) #37227
rressi-at-globus
force-pushed
the
feature/cryptopp-8.9.0_1
branch
from
August 28, 2024 08:24
dc9a63a
to
931ad9a
Compare
Please modify the vcpkg.json file as below:
|
Cheney-W
reviewed
Aug 29, 2024
Cheney-W
added
the
category:port-bug
The issue is with a library, which is something the port should already support
label
Aug 29, 2024
Co-authored-by: Cheney Wang <[email protected]>
Update git-tree for version 8.9.0
Cheney-W
requested changes
Sep 6, 2024
Co-authored-by: Cheney Wang <[email protected]>
Cheney-W
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37227
When we use library cryptopp from a CMake project, we have compilation issue on Debug with this
simple inclusion directive:
Occurs with:
For references I report here some traces from my toolchain file: