Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c-ares] Update port to 1.33.1 #40646

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[c-ares] Update port to 1.33.1 #40646

merged 2 commits into from
Sep 3, 2024

Conversation

mikaellindemann
Copy link
Contributor

@mikaellindemann mikaellindemann commented Aug 26, 2024 •
edited
Loading

c-ares has released version 1.33.1 to fix an issue with resolving non-FQDN domains using search domains when using systemd-resolved.

gRPC depends on c-ares, using it as it's default DNS resolver (at least on Linux, I believe on other operating systems too). Since systemd-resolved is common on Ubuntu systems, which is often offered in cloud hosting, this could affect a lot of people.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@mikaellindemann
Copy link
Contributor Author

@microsoft-github-policy-service agree company="twig.energy"

@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Aug 26, 2024
@dg0yt dg0yt mentioned this pull request Aug 26, 2024
Open
@mikaellindemann
Copy link
Contributor Author

I'm unsure if the failing build of octave is related to this change.
When I build it locally it does not seem to build c-ares.

Also, the build works on Ubuntu 22.04:

./vcpkg install octave
Computing installation plan...
The following packages will be built and installed:
    octave:[email protected]
Detecting compiler hash for triplet x64-linux...
Compiler found: /usr/bin/c++
Restored 0 package(s) from /home/mikael/.cache/vcpkg/archives in 8.09 us. Use --debug to see more details.
Installing 1/1 octave:[email protected]...
Building octave:[email protected]...
-- Note: octave only supports dynamic library linkage. Building dynamic library.
-- The Fortran compiler identification is GNU 11.4.0
-- Downloading https://ftpmirror.gnu.org/octave/octave-9.2.0.tar.xz -> octave-9.2.0.tar.xz...
-- Extracting source /home/mikael/dev/vcpkg/downloads/octave-9.2.0.tar.xz
-- Using source at /home/mikael/dev/vcpkg/buildtrees/octave/src/octave-9-0507d3871c.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Generating configure for x64-linux
-- Finished generating configure for x64-linux
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Installing x64-linux-dbg
-- Building x64-linux-rel
-- Installing x64-linux-rel
-- Installing: /home/mikael/dev/vcpkg/packages/octave_x64-linux/share/octave/copyright
-- Fixing pkgconfig file: /home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/pkgconfig/octave.pc
-- Fixing pkgconfig file: /home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/pkgconfig/octinterp.pc
-- Fixing pkgconfig file: /home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/pkgconfig/octave.pc
-- Fixing pkgconfig file: /home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/pkgconfig/octinterp.pc
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/liboctave.so.11.0.1' (From '' -> To '$ORIGIN:$ORIGIN/../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/liboctinterp.so.12.0.1' (From '/home/mikael/dev/vcpkg/installed/x64-linux/debug/lib/octave/9.2.0' -> To '$ORIGIN:$ORIGIN/../..:$ORIGIN/../../octave/9.2.0')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__delaunayn__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__fltk_uigetfile__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__glpk__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__init_fltk__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__init_gnuplot__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__ode15__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__voronoi__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/audiodevinfo.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/audioread.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/convhulln.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/fftw.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/debug/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/gzip.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/liboctave.so.11.0.1' (From '' -> To '$ORIGIN:$ORIGIN/../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/liboctinterp.so.12.0.1' (From '/home/mikael/dev/vcpkg/installed/x64-linux/lib/octave/9.2.0' -> To '$ORIGIN:$ORIGIN/../..:$ORIGIN/../../octave/9.2.0')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__delaunayn__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__fltk_uigetfile__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__glpk__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__init_fltk__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__init_gnuplot__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__ode15__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/__voronoi__.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/audiodevinfo.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/audioread.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/convhulln.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/fftw.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/lib/octave/9.2.0/oct/x86_64-pc-linux-gnu/gzip.oct' (From '' -> To '$ORIGIN:$ORIGIN/../../../..')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/bin/mkoctfile-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../lib')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/bin/octave-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../lib')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/bin/octave-cli-9.2.0' (From '/home/mikael/dev/vcpkg/installed/x64-linux/lib/octave/9.2.0' -> To '$ORIGIN:$ORIGIN/../../../lib:$ORIGIN/../../../lib/octave/9.2.0')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/bin/octave-config-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../lib')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/debug/bin/mkoctfile-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../../debug/lib')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/debug/bin/octave-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../../debug/lib')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/debug/bin/octave-cli-9.2.0' (From '/home/mikael/dev/vcpkg/installed/x64-linux/debug/lib/octave/9.2.0' -> To '$ORIGIN:$ORIGIN/../../../../debug/lib:$ORIGIN/../../../../debug/lib/octave/9.2.0')
-- Adjusted RPATH of '/home/mikael/dev/vcpkg/packages/octave_x64-linux/tools/octave/debug/bin/octave-config-9.2.0' (From '' -> To '$ORIGIN:$ORIGIN/../../../../debug/lib')
-- Performing post-build validation
Stored binaries in 1 destinations in 19 s.
Elapsed time to handle octave:x64-linux: 7 min
octave:x64-linux package ABI: 042016018a8260b99eb04d24c68817d39a878882d53a9471804dffc96c70c2ba
Total install time: 7 min
octave provides pkg-config modules:

  # C++ interface to GNU Octave underlying library.
  octave

  # C++ interface to GNU Octave interpreter.
  octinterp

@WangWeiLin-MV
Copy link
Contributor

I'm unsure if the failing build of octave is related to this change.
When I build it locally it does not seem to build c-ares.

This is a CI issue, and we are fixing it.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 31, 2024

The CI issue is fixed...

WangWeiLin-MV
WangWeiLin-MV approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Sep 2, 2024
@vicroms vicroms merged commit 52f11d7 into microsoft:master Sep 3, 2024
16 checks passed
@mikaellindemann mikaellindemann deleted the port/c-ares-1.33.1 branch September 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikaellindemann @WangWeiLin-MV @dg0yt @vicroms