Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: code cleanup #1177

Merged
merged 2 commits into from
Dec 8, 2024
Merged

refactor: code cleanup #1177

merged 2 commits into from
Dec 8, 2024

Conversation

chavacava
Copy link
Collaborator

This PR:

  1. removes unused code
  2. replaces byte buffers with string builders when possible
  3. removes if-then-else chains with switch and/or reduce nesting
  4. renames some local variables

denisvmedia
denisvmedia approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@denisvmedia denisvmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chavacava chavacava merged commit f6a3820 into master Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisvmedia denisvmedia denisvmedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chavacava @denisvmedia