Write valid leader without counting #527 #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just appending the incoming leader elements, this adds the static values for Pos: 00-04, 10-16, 20-23. By using `0`as default value for Pos: 00-04 and 12-16. #527 (comment)
TobiasNx
force-pushed
the
527-output-valid-leader
branch
from
ea05347
to
a0f2736
Compare
|
What's the point of doing the "easy" solution now that we already have the "hard" solution? |
|
The leader is always valid? |
blackwinter
requested changes
Jun 26, 2024
|
I will put this on hold, the failing test hints that it is not as easy: issue336_createRecordWithTopLevelLeader_defaultMarc21Xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just appending the incoming leader elements by
encode-marcmxl, this adds the static values for Pos: 00-04, 10-16, 20-23.By using
0as default value for Pos: 00-04 and 12-16.#527 (comment)