Merge pull request #527 from maks/521-view-files-without-texteditor

fix handling js mimetypes
maks · Mar 3, 2020 · 3d708fe · 3d708fe
2 parents 0caeb52 + 15c9407
commit 3d708fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/src/main/java/me/sheimi/android/utils/FsUtils.java b/app/src/main/java/me/sheimi/android/utils/FsUtils.java
@@ -126,9 +126,8 @@ public static void openFile(SheimiFragmentActivity activity, File file) {
             activity.startActivity(intent);
             activity.forwardTransition();
         } catch (ActivityNotFoundException e) {
-            //This can occur if no app for file type or more than one app
+            // Looks like many editor apps only register for VIEW not EDIT intents :-(
             intent.setAction(Intent.ACTION_VIEW);
-            intent.setFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION | Intent.FLAG_GRANT_WRITE_URI_PERMISSION);
             try {
                 activity.startActivity(intent);
                 activity.forwardTransition();
@@ -201,4 +200,7 @@ public static File joinPath(File dir, String relative_path) {
         return new File(dir.getAbsolutePath() + File.separator + relative_path);
     }
 
+    public static boolean isTextMimeType(String mime) {
+        return mime.startsWith("text") || mime.equals("application/javascript") || mime.equals("application/json");
+    }
 }
diff --git a/app/src/main/java/me/sheimi/sgit/fragments/FilesFragment.java b/app/src/main/java/me/sheimi/sgit/fragments/FilesFragment.java
@@ -87,7 +87,7 @@ public void onItemClick(AdapterView<?> adapterView,
                             return;
                         }
                         String mime = FsUtils.getMimeType(file);
-                        if (mime.startsWith("text")) {
+                        if (FsUtils.isTextMimeType(mime)) {
                             Intent intent = new Intent(getActivity(),
                                     ViewFileActivity.class);
                             intent.putExtra(ViewFileActivity.TAG_FILE_NAME,