Update target frameworks. #2564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces support for
.NET 4.5and.NET Standard 1.3with support for.NET Standard 2.0,.NET Standard 2.1,.NET 8.0and.NET 9.0.The justification is that
.NET 4.5and.NET Standard 1.3are very old..NET 4.5has been end-of-life for 8 years (since 2016/01/12), and the only frameworks supported by.NET Standard 1.3that aren't supported by.NET Standard 2.0have also been dead for a long time.They are so old in fact that
System.Buffers(a dependency of LiteDB) has released an update not supported by.NET Standard 1.3.While
.NET Standard 2.1only supports.NET,.NET Standard 2.0supports all supported versions of.NET Framework, so there should be almost no one left out.With the removal of
.NET 4.5and.NET Standard 1.3, I've been able to remove several instances of conditional compilation. In the future, LiteDB will have a larger range of APIs to work with.Additionally, supporting
.NET 8.0and.NET 9.0should give performance boosts when using those versions.This pull request has created a number of warnings in LiteDB due to various APIs becoming obsolete. I think the team should look at each case individually and look to replace the APIs with newer alternatives.