fix: fix uri encode

[maxdeichmann]

Important

Fixes URI encoding in encodeQueryParams by encoding keys and values with encodeURIComponent and handling Date objects.

• Behavior:
  • Fixes URI encoding in encodeQueryParams function in utils.ts.
  • Encodes both keys and values using encodeURIComponent.
  • Converts Date objects to ISO strings before encoding.
• Misc:
  • Removes use of URLSearchParams in encodeQueryParams.

^{This description was created by for a4b75ab. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
langfuse-js	✅ Ready (Inspect)	Visit Preview	Oct 8, 2024 11:31pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to a4b75ab in 10 seconds

More details

• Looked at 32 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. langfuse-core/src/utils.ts:116

• Draft comment:
  Consider using a more concise approach to filter out null values directly in the map function for better readability and performance.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The current implementation of encodeQueryParams correctly encodes both keys and values, including handling Date objects. However, it can be optimized for readability and performance by directly filtering out null values in the map function.

Workflow ID: wflow_CNBGOoRaJU1bTQMN

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.