feat: extend coverage of API #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RichardKruemmel
commented
Aug 1, 2024
•
RichardKruemmel
commented
- fetchScores
- fetchPrompts
- getDatasetItems
- getDatasets
- fetchScore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marcklingen
reviewed
Aug 1, 2024
… fetching prompts
…l query parameters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Extended API coverage with new methods and tests for scores, prompts, datasets, and dataset items.
- integration-test/langfuse-integration-datasets.spec.ts: Added tests for creating and fetching datasets and dataset items, including special characters and pagination.
- integration-test/langfuse-integration-node.spec.ts: Added tests for creating and fetching scores and prompts.
- langfuse-core/src/index.ts: Introduced methods
fetchScore,fetchScores,fetchPrompts,getDatasetItems, andgetDatasetsinLangfuseCoreStatelessandLangfuseCore. - langfuse-core/src/types.ts: Added new types for fetching scores, prompts, datasets, and dataset items.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
|
Looking forward to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.