-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add jsdoc across main methods of sdk #247
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/types.ts
: Added detailed JSDoc comments to various TypeScript types and interfaces.- Documentation Scope: Focused on constructor, low-level tracing, Langchain integration, prompts, and datasets.
- Improved Clarity: JSDoc comments now provide clear descriptions of interface properties.
- Non-Intrusive Changes: No functional changes; existing functionality remains unaffected.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/types.ts
: Added detailed JSDoc comments to various TypeScript types and interfaces.- Documentation Scope: Focused on constructor, low-level tracing, Langchain integration, prompts, and datasets.
- Improved Clarity: JSDoc comments now provide clear descriptions of interface properties.
- Non-Intrusive Changes: No functional changes; existing functionality remains unaffected.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/index.ts
: Updated JSDoc forgetDatasetRuns
andgetDataset
methods to improve clarity and accuracy.langfuse-core/src/types.ts
: Added detailed JSDoc comments to interfaces likeGetLangfuseDatasetResponse
andCreateLangfuseGenerationBody
.- Documentation Scope: Focused on constructor, low-level tracing, Langchain integration, prompts, and datasets.
- Improved Clarity: JSDoc comments now provide clear descriptions of interface properties.
- Non-Intrusive Changes: No functional changes; existing functionality remains unaffected.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/openapi/server.ts
: Added detailed JSDoc comments to properties and methods in the OpenAPI schema definitions, enhancing clarity.langfuse-core/src/types.ts
: Included comprehensive JSDoc comments for various types and interfaces, improving documentation and developer experience.
No functional changes; existing functionality remains unaffected.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/index.ts
: Corrected return type in JSDoc forgetDatasetRuns
method fromGetLangfuseDatasetResponse
toGetLangfuseDatasetRunsResponse
, ensuring accurate documentation.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/openapi-spec/openapi-server.yaml
: Added new query parameters and descriptions to existing API endpoints for better filtering and documentation.langfuse-core/src/openapi/server.ts
: Updated JSDoc comments for clarity and consistency; added optional filters for version and release in query parameters.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Enhanced JSDoc comments across main SDK methods for improved documentation and usability.
langfuse-core/src/types.ts
: Added new properties (version
,release
,promptName
,promptVersion
) toGetLangfuseTracesQuery
,GetLangfuseObservationsQuery
, andGetLangfuseObservationResponse
types.langfuse-core/openapi-spec/openapi-server.yaml
: Added new query parameters and descriptions to existing API endpoints for better filtering and documentation.langfuse-core/src/openapi/server.ts
: Updated JSDoc comments for clarity and consistency; added optional filters for version and release in query parameters.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
scope
docs: https://langfuse.com/docs/sdk/typescript/guide