-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add needle as custom component #4657
base: main
Are you sure you want to change the base?
Conversation
Picking this up now again, since Needle is now officially available in Langchain Community Package: |
CodSpeed Performance ReportMerging #4657 will degrade performances by 43.9%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inherits from CustomComponent
instead of Component
which is the standard since 1.0
.
ChatGPT or our Custom Component Generator template might be able to help you migrate it. You can use an example component like NotDiamondComponent
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks man! Will have a look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogabrielluiz I adjusted now. Works fine.
@ogabrielluiz worked on this a bit this Saturday afternoon. Should be ok now using the Component and being able to be used with other components. |
Overview
Really cool project, I like it. Looking forward to integrate and work with you.
Needle can also generate an Answer (Full RAG)
Or retrieve the chunks and further do something with it. (Let user decide what to do with chunks.)
Depends on
Depends on my other PR, where I contribute Needle to Langchain.
langchain-ai/langchain#28157