Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

PHP8.4 Support Added #13

Merged
merged 1 commit into from
Oct 16, 2024
Merged

PHP8.4 Support Added #13

merged 1 commit into from
Oct 16, 2024

Conversation

cod43156
Copy link
Contributor

@cod43156 cod43156 commented Oct 8, 2024

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

@arhimede
Copy link
Member

arhimede commented Oct 8, 2024

@gsteel @alexmerlin
This kind of PR can be closed with a phrase like
"This is not helpful - you can’t even be bothered to sign-off your commits…" ?
Or we should use a different phrase ?

@froschdesign
Copy link
Member

@arhimede
Or ignore the DCO.

@froschdesign
Copy link
Member

This component is still used in some components, like laminas-http.

@nishant04412
Copy link

@froschdesign Do we need to use Sign-off in commit message mandatorily ? We can amend that commit message if needed.

Signed-off-by: Raj Mohan <[email protected]>
@alexmerlin
Copy link
Member

@arhimede @froschdesign The DCO issue has been fixed by the author.

The only issue left is with the Autocloser, which seems to be failing almost constantly - as seen in the Actions.

If the Autocloser check is not mandatory, then this PR can be merged and released.
After this, @mkoprek can finalize their PR on laminas/laminas-diagnostics, which is blocked by this PR.

@arhimede
Copy link
Member

@alexmerlin
autocloser is supposed to close PRs but uses wrong event and fails
It is not part of CI

@arhimede arhimede self-requested a review October 16, 2024 09:05
Copy link
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can ignore the Autocloser action in this case.
The repo is anyway in security-only mode

@arhimede arhimede merged commit f2eedd3 into laminas:2.11.x Oct 16, 2024
14 of 15 checks passed
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cod43156

@gsteel gsteel added this to the 2.11.0 milestone Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants