WIP: Fixing muilt-arch image builds

[vamage]

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fixing the docker file for multi-arch builds as it currently only works for native arch. Currently the build process only copies the ./bin/iscsiplugin to all built images instead of ./bin/iscsiplugin-$ARCH causing exec /iscsiplugin: exec format error because:
iscsiplugin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=69pHWuyHaqIJGzRCAB4A/dC8bXCTAacAAIfzDgxdr/QKo4BKFZMVWEunvrdxYZ/ZVyRnJRB4H_MT4it7Iy8, with debug_info, not stripped

Which issue(s) this PR fixes:
Fixes : #217

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

Fixing `exec /iscsiplugin: exec format error` on non-amd64 linux images

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vamage (7003b9b)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vamage
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @vamage!

It looks like this is your first PR to kubernetes-csi/csi-driver-iscsi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-iscsi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vamage. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vamage]

oops looks like i misspelled iscsi as isci 🤦

[andyzhangx]

why not use following path?

ARG binary=./bin/${ARCH}/iscsiplugin
COPY ${binary} /iscsiplugin

https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/Dockerfile#L18

[vamage]

Sure, let me look this afternoon. I think there was some reason i saw in the makefile.

[andyzhangx]

/ok-to-test

[vamage]

didn't realize i couldn't touch release-tools. I'll need to rethink the approach. Let me mark this as WIP.

[k8s-ci-robot]

@vamage: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-csi-csi-driver-iscsi	7003b9b	link	true	/test pull-kubernetes-csi-csi-driver-iscsi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.