-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert code to full integration with support for input and events from Plejd #54
base: master
Are you sure you want to change the base?
Conversation
After testing this weekend: I could not get the physical button inputs on the pucks to send sensible BLE messages (and even getting a Plejd ID assigned), so I had to remove |
Hi.
|
Any output will be shown as dimmable if it at any time has reported a brightness value. Can you go to |
It reverts to dimmable after ha restart. |
f84d8a0
to
c879f2a
Compare
The above issue is now fixed, by making a light dimmable only if it any time its brightness values has changed. |
SPR-01 tested
This PR is now updated with the recent changes that has been merged into master. The Please consider accepting this PR or make a statement that you don't want to take it, since almost any other PR will have merge issues with this one. |
Hi :) I haven't spent real time on this in some time, when/if I spend time on plejd again I will probably try to contribute to https://github.com/thomasloven/hass_plejd/ rather than continue this integration. My only issue with this is that it adds a significant amount of code and changes to something I'm not likely to continue supporting for very long. Do you have opinions here? |
Thanks for your input, I certainly do understand! I also have contributed to hass_plejd and will probably migrate to that once it becomes a little more mature, so I don't really mind if you don't plan to keep supporting this project. I just wanted to contribute back with something that has been working for me the last 18 months :) I'll leave the PR open for others to discover the possibilities within, and let you decide if you want to merge it. |
light
platform is kept mostly as-is, with slightly better detection of dimmable non-dimmable lightsswitch
platform is added, functioning exactly the same as a non-dimmable light (just a different HA UI)binary_sensor
platform is added for wireless buttons (WPH-01)sensor
platform is added for rotary buttons (WRT-01, VRI-02)As part of the rewrite, the Plejd communication is isolated to the
PlejdService
andPlejdBus
classes, and the code is rewritten to adhere to HA code standards.Also note that the yaml configuration has changed significantly and must be rewritten if an existing installation is updated.