autodisable curl tests #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teto
commented
Jun 17, 2022
teto
commented
- added .editorconfig
- tests: autodisable test in absence of curl
added 2 commits
June 17, 2022 11:11
to ease contributing to the project
When running the test in the nix sandbox, there is no internet access and this specific test fails. The best solution would probably be to download these files only when they dont exist. The current fix skips the test when curl is not available and allows to move on.
kkharji
reviewed
Jun 17, 2022
| @@ -546,6 +546,10 @@ describe("sqlite.db", function() | |||
| end) | |||
|
|
|||
| describe(":select", function() | |||
| if vim.fn.executable("curl") then | |||
| pending("'curl' program is not available") | |||
There was a problem hiding this comment.
what's pending 🤔 , part of busted framework?
There was a problem hiding this comment.
yes. To test you can replace curl with dadadsadad to fail the condition and check the output.
|
I've copied the .editorconfig from neovim because by default I was adding tabs to the file. I can drop it if you dont like it. |
no, that's fine, I don't mind it |
|
@teto you would need a release right 😃 |
|
yes that would help ^^. I can always test with a fork but that takes more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.