Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type assert): add more check for type assert #246

Merged
merged 3 commits into from
Jun 20, 2024
Merged

fix(type assert): add more check for type assert #246

merged 3 commits into from
Jun 20, 2024

Conversation

meteorgan
Copy link
Contributor

fix #224

@meteorgan meteorgan marked this pull request as ready for review April 17, 2024 13:44
dtcaciuc
dtcaciuc requested changes May 14, 2024
View reviewed changes
errcheck/errcheck.go Show resolved Hide resolved
@meteorgan meteorgan requested a review from dtcaciuc June 7, 2024 09:29
dtcaciuc
dtcaciuc previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@dtcaciuc dtcaciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one more nit, otherwise LGTM

errcheck/errcheck.go Outdated Show resolved Hide resolved
dtcaciuc
dtcaciuc approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@dtcaciuc dtcaciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dtcaciuc dtcaciuc merged commit f3c8b3c into kisielk:master Jun 20, 2024
5 checks passed
@Ragnar-BY Ragnar-BY mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtcaciuc dtcaciuc dtcaciuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report unchecked type-assertion when returning value and when passing it to other func
2 participants
@meteorgan @dtcaciuc