Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/recursive-dir-creation #25

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

brian-mulier-p
Copy link
Member

Needed for kestra-io/kestra#2457 to work as it requires being able to list at root of internal storage to identify namespaces (which is currently not possible as we don't create all the in-between directory which makes it invisible for our storage implementation listing)

@brian-mulier-p brian-mulier-p self-assigned this Nov 8, 2023
src/test/java/io/kestra/storage/s3/S3StorageTest.java Outdated Show resolved Hide resolved
src/main/java/io/kestra/storage/s3/S3Storage.java Outdated Show resolved Hide resolved
src/main/java/io/kestra/storage/s3/S3Storage.java Outdated Show resolved Hide resolved
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…on creating a resource or directory for listing to work properly
@brian-mulier-p brian-mulier-p force-pushed the fix/recursive-dir-creation branch from ae94ca0 to 98f8677 Compare November 8, 2023 14:31
@brian-mulier-p brian-mulier-p merged commit 470b5b9 into master Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants