Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slf4j-api module, to better represent the Java 9 compatible module name #245

Open
wants to merge 2 commits into
base: v1
Choose a base branch
from

Conversation

rolaca11
Copy link

The currently used slf4j-api version (1.7.26) has not been made with the new modular system of Java 9 in mind. This means that there isn't a module-info.java file in the provided dependency.

To overcome this, in the org.pcap4j.core module, the artifact id of the slf4j-api has been required.

This, however, isn't compatible with the modular version of slf4j-api, which means that users of this (pcap4j) artifact cannot make use of the modular slf4j version, because, during compile, the requires transitive slf4j.api; requirement will not be met by the modular slf4j-api version.

For this reason, I raised the slf4j-api version in the parent POM and made it so that the org.pcap4j.core module requires the intended org.slf4j module instead.

change slf4j module, to represent the designed module name, instead of the artifact name
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 69.868% when pulling ef97c38 on rolaca11:v1 into 0b4fad8 on kaitoy:v1.

@kaitoy
Copy link
Owner

kaitoy commented Dec 28, 2019

logback 1.0.0 that's used for Pcap4J testing doesn't work with SLF4J 1.8.
It seems any released versions of logback don't work with SLF4J 1.8 neither...

@Adito5393
Copy link

I encounter the same issue. Could you try using slf4j-api:2.0.0-alpha1?

This contains the module-info with the name org.slf4j that is required here also.

@Adito5393
Copy link

There is a newer logback version available that uses SLF4J 2.0:

"Latest STABLE version
The latest stable logback is version 1.2.3.

EXPERIMENTAL/UNSTABLE requiring SLF4J version 2.0.x
The current actively developped version is 1.3.0-alpha5."

@kaitoy Would you be willing to try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants