Fix Slf4j-api module, to better represent the Java 9 compatible module name #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used
slf4j-api
version (1.7.26) has not been made with the new modular system of Java 9 in mind. This means that there isn't amodule-info.java
file in the provided dependency.To overcome this, in the
org.pcap4j.core
module, the artifact id of theslf4j-api
has been required.This, however, isn't compatible with the modular version of
slf4j-api
, which means that users of this (pcap4j) artifact cannot make use of the modular slf4j version, because, during compile, therequires transitive slf4j.api;
requirement will not be met by the modularslf4j-api
version.For this reason, I raised the
slf4j-api
version in the parent POM and made it so that theorg.pcap4j.core
module requires the intendedorg.slf4j
module instead.