Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set test_args if empty #127

Merged
merged 1 commit into from
Oct 19, 2024
Merged

don't set test_args if empty #127

merged 1 commit into from
Oct 19, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 19, 2024

Otherwise you get the empty kwarg entry test_args=String[]

│
│ To reproduce this CI run locally run the following from the same repository state on julia version 1.10.5:
│
│ `import Pkg; Pkg.test(;coverage=true, julia_args=["--check-bounds=yes", "--compiled-modules=yes"], test_args=String[], force_latest_compatible_version=false, allow_reresolve=true)`
│

@IanButterworth IanButterworth requested a review from a team as a code owner October 19, 2024 00:52
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f5f652a) to head (c7f601d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth IanButterworth merged commit 1e03e01 into main Oct 19, 2024
32 checks passed
@IanButterworth IanButterworth deleted the ib/test_args_empty branch October 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants