Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plugin types are exposed #82

Closed
wants to merge 1 commit into from

Conversation

junemolison
Copy link

chore: release v2.0.7
chore: update deps
fix: ensure plugin types are exposed

🔗 Linked issue

  • none

📚 Description

Fixed import of defineNuxtPlugin to properly expose types accordingly to template: https://github.com/nuxt/starter/blob/module/src/runtime/plugin.ts

chore: release v2.0.7

chore: update deps
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for nuxt-gtag ready!

Name Link
🔨 Latest commit fb6106d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-gtag/deploys/668bc74bd5bf720007f39e88
😎 Deploy Preview https://deploy-preview-82--nuxt-gtag.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner

Thanks for the PR! But why not keep #imports, do you run into any issues?

@johannschopplich
Copy link
Owner

I believe using #imports is the correct way here, as all other Nuxt modules use it at the moment. For example:

https://github.com/nuxt-modules/color-mode/blob/0aed5962b4b6e2880f90c713b6773624e276bcec/src/runtime/plugin.client.ts#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants