Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing schema validation for mysql when boolean/enum is used #26759

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pmverma
Copy link
Member

@pmverma pmverma commented Jul 18, 2024

Fix #25421

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pmverma
❌ pmohan


pmohan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pmverma pmverma marked this pull request as ready for review July 18, 2024 18:43
@pmverma pmverma self-assigned this Jul 18, 2024
@mraible
Copy link
Contributor

mraible commented Oct 30, 2024

@pmverma Can you please fix conflicts?

@pmverma
Copy link
Member Author

pmverma commented Oct 30, 2024

Hi @mraible I have fixed the conflicts.
While this PR solves the issue with boolean and ENUM for MySQL, multiple other datatypes are failing the Hibernate schema validation. Some are visible in CI tests in this PR as well.

Please see #26761

I would prefer to hold this until https://hibernate.atlassian.net/browse/HHH-18257 is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema validation can fail when ENUM or boolean types are used in entities with MySQL.
3 participants