-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #882
Conversation
d365d47
to
c80aa77
Compare
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0 BREAKING CHANGE: Requires ESLint@^6.x
c80aa77
to
dd6cbb6
Compare
Thanks but I don't know when we'll be able to land this since we tend to match supported node versions with Jest, which still supports v10 and I'd like to avoid adding more long-living PRs to our already decent list. |
I'm fine making a breaking change dropping node 10 (and eslint 5 if needed) |
@SimenB Since we have I'm happy to re-open the PR. |
@MichaelDeBoey let's do it, lot's of other deps we can update at the same time 🙂 But let's start just by dropping eslint 5 and node 10 without adding pre-release |
@SimenB Since
|
Not if we support both v4 and v5, right? EDIT: I see the range is already |
@SimenB Running it with v5 will break peerDependency of
That should actually be |
Why would it break? |
@SimenB |
Right, but that only affects users of the plugin, not us (I think) as we don't pull in the plugin, the user does |
It technically affects our users too since it's our |
For us it's an optional one, we don't care which one the user pulls in. Us supporting two versions with different peer deps of their own doesn't matter, the user just pulls in the correct versions they use |
Regardless, we can start by dropping node v10 and eslint v5 on a |
|
Superseded by #903