Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API to 2.12 #234

Closed
wants to merge 3 commits into from
Closed

Updated API to 2.12 #234

wants to merge 3 commits into from

Conversation

rwky
Copy link

@rwky rwky commented Mar 19, 2018

No description provided.

@rwky rwky mentioned this pull request Mar 19, 2018
@rwky
Copy link
Author

rwky commented Mar 19, 2018

Supersedes #220 #199

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a3 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

4 similar comments
@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a3 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a3 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a3 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a3 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b868a62 on rwky:api-version-2.12 into 82a5d8f on jaredhanson:master.

@rwky rwky force-pushed the api-version-2.12 branch from 8b3e8a3 to b868a62 Compare March 19, 2018 18:01
@lumaxis
Copy link

lumaxis commented Mar 27, 2018

@jaredhanson Any chance we can get this merged and released soon-ish? 🙂
Let me know if I can do anything to help!

@ttsirkia
Copy link

Is this repository still maintained or should we use a fork which already includes version 2.12?

@isitgeorge
Copy link

Doesn't look like this is going to merged anytime soon. You can also force API 2.12 by modifying the authorizationURL, profileURL and tokenURL parameters.

passport.use(new FacebookStrategy({
    clientID: FACEBOOK_APP_ID,
    clientSecret: FACEBOOK_APP_SECRET,
    callbackURL: "http://localhost:3000/cb",
    profileURL: 'https://graph.facebook.com/v2.12/me',
    authorizationURL: 'https://www.facebook.com/v2.12/dialog/oauth',
    tokenURL: 'https://graph.facebook.com/v2.12/oauth/access_token'
  },
  function(accessToken, refreshToken, profile, cb) {
    ...
  }
));

tim-soft added a commit to tim-soft/DefinitelyTyped that referenced this pull request Jul 5, 2018
@rwky
Copy link
Author

rwky commented Jul 7, 2018

@jaredhanson
Copy link
Owner

I've published [email protected] to npm. This version updates to the latest version of Graph API, v3.2. It includes an equivalent graphAPIVersion option, the casing changed to match conventions througout the rest of this and other passport strategies.

Closing.

MrOrz added a commit to cofacts/rumors-api that referenced this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants