- Method added to prototype that handle requested params that does no… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist on FB profile response; - Object "processed" added to profile returned object which include all requested params with a null value when FB does not provide it. - Test cases - IIFE pattern and use strict added to strategy.js
2 similar comments
added 2 commits
November 16, 2016 23:42
- added property nullEmptyResponse to config object to control to null empty response or not
|
sorry about coverage. Tested the change locally on a project and forgot to include a validation before sending it out; Fixed already. |
|
@jungleBadger if you make a PR against https://github.com/passport-next/passport-facebook is will get looked into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method added to prototype that handle requested params that does not exist on FB profile response;