Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW test optimizations #327

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Kampi
Copy link
Collaborator

@Kampi Kampi commented Jul 24, 2024

  • Pass J-Link serial and hardware revision as arguments to pytest
  • Add a setup for different hardware revisions and J-Links to CI/CD
  • Add support for ARM 64
  • Add support for PPK2
  • Skip the test when the target J-Link isn´t connected
  • Device recovering
  • Test report

@Kampi Kampi added the enhancement New feature or request label Jul 24, 2024
@Kampi Kampi requested a review from ldab July 24, 2024 06:01
app/pytest/utils.py Outdated Show resolved Hide resolved
app/pytest/pytest.ini Outdated Show resolved Hide resolved
app/pytest/pytest.ini Outdated Show resolved Hide resolved
@Kampi Kampi self-assigned this Jul 24, 2024
@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch 3 times, most recently from 3228021 to f24147f Compare July 24, 2024 06:26
app/pytest/pytest.ini Outdated Show resolved Hide resolved
@ldab

This comment was marked as outdated.

@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch from f24147f to d2a1b1a Compare July 24, 2024 06:59
@Kampi

This comment was marked as outdated.

@ldab
Copy link
Collaborator

ldab commented Jul 24, 2024

So the way I imagined it is like

  1. yml file has a matrix with Self-runner name + HW version + Serial
  2. Pytest …. $matrix

The self hosted runner name is important on a matrix because I have one now, Jakob may set up another one and so on…. And maybe we need another argument with features if you set up one with a PowerProfiler 🤯 so that not all tests would apply anymore

So the way I imagined it is like

  1. yml file has a matrix with Self-runner name + HW version + Serial
  2. Pytest …. $matrix

The self hosted runner name is important on a matrix because I have one now, Jakob may set up another one and so on…. And maybe we need another argument with features if you set up one with a PowerProfiler 🤯 so that not all tests would apply anymore

I added two matrices for the J-Links and the HW revisions so we can start in a simple way with it. Ofc we need a way to pass options because maybe you also want to compare debug and release build too.

Seem right, @jakkra I thought computer name can be passed as argument but apparently only labels https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/using-self-hosted-runners-in-a-workflow#about-self-hosted-runner-labels can you please check what labels are available on this runner?

@Kampi

This comment was marked as outdated.

@ldab

This comment was marked as outdated.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch from d2a1b1a to d22e606 Compare July 24, 2024 07:49
@Kampi

This comment was marked as outdated.

@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch 2 times, most recently from 07f382a to 5733243 Compare July 24, 2024 08:07
@Kampi

This comment was marked as outdated.

@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch from 5733243 to a63b38d Compare July 24, 2024 08:19
@ldab

This comment was marked as outdated.

@Kampi

This comment was marked as outdated.

@ldab

This comment was marked as outdated.

@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch from a63b38d to e701919 Compare July 24, 2024 08:31
@Kampi

This comment was marked as outdated.

@ldab

This comment was marked as outdated.

@ldab

This comment was marked as outdated.

@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch 28 times, most recently from 9d00280 to 10dfc46 Compare July 25, 2024 18:23
- Pass J-Link serial and hardware revision as arguments to pytest
- Add a setup for different hardware revisions and J-Links to CI/CD
- Add support for ARM 64
- Add support for PPK2
- Skip the test when the target J-Link isn´t connected
- Device recovering
@Kampi Kampi force-pushed the Move_Serialnumber_to_Config branch from 10dfc46 to 2d63ca3 Compare July 25, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants