Support for reading movies with frame headers #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zachary-Ip
approved these changes
Jan 16, 2024
nosheen-adil
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Looks good to me, found one small issue with a suggested fix.
While testing this I discovered a bug. The api does not support dropped frames. If I try to the read the last frame of a movie with dropped frames, I get an error, because the api is not correctly accounting for the actual number of frames stored on disk. I'll create a follow up issue for this.
|
Issue created for the dropped frames issue here: #42 |
|
@nosheen-adil thank you!
that is huge, FYI @Zachary-Ip |
Co-authored-by: Nosheen Adil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
this PR supports reading movies with frame headers, which means that it can now read multi-plane and multi-color movies
technical discussion
the goal of this repo has always been to act and behave like the IDPS API as much as possible. with the IDPS API, you can read multi-color or -plane movies directly. the way these movies are organized is that frames from subsequent channels/planes are simply stored one after the other, and you can simply read them like a normal movie. of course, this is not very useful, because you're mixing up channels/planes.
the IDPS API provides a deinterleave function, which is not part of this PR. the goal of this PR is to simply match what the IDPS API does with multi-color or mulit-plane movies
checklist
testing