Add vessel set #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Zachary-Ip
commented
Nov 27, 2023
Zachary-Ip
commented
- VesselSet class added
- test_vesel_set added
added 2 commits
November 27, 2023 12:13
Open
sg-s
suggested changes
Dec 1, 2023
|
|
||
| vessel_obj.show_footer() | ||
| im = vessel_obj.get_vessel_image_data(0) | ||
| assert im.shape[0] > 0 and im.shape[1] > 0, "Expected image to have data" |
There was a problem hiding this comment.
we need stronger checks -- make sure the size is what you think it is
| assert im.shape[0] > 0 and im.shape[1] > 0, "Expected image to have data" | ||
|
|
||
| trace = vessel_obj.get_vessel_trace_data(0) | ||
| assert trace.shape[0] > 0, "Expected trace to have data" |
There was a problem hiding this comment.
verify that the shape is what it should be
|
Closing since this functionality is now available in v2 api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.