Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt /example fixes #940 #960

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Conversation

ironicbrew
Copy link

Large diff but only one file (README.md) outside of the /example directory has been altered and now uses a relative repo link. Most file changes are a side effect of initing a new react-native app in /example.

  • Previous version of App.js remains largely the same minus some code cleanup and improved UI/UX.
  • Fixed state management issue/state overlap(ie. peripherals and peripheralList)
  • Use of Map() was outside of a useState causing rerender issues
  • Connected devices now display their state automatically
  • Added example/README.md with standalone instructions
  • Import of react-native-ble-manager changed from relative import to standalone npm module as I think this brings the example more in line with being truely standalone.
  • Removed pizza example

Note: I don't currently have a working Android device so I wasn't able to test this on Android beyond using a simulator.

Happy to tweak as needed, just let me know.

Cheers!

@ironicbrew ironicbrew changed the title Rebuilt Example Rebuilt /example Feb 12, 2023
@ironicbrew ironicbrew mentioned this pull request Feb 12, 2023
@ironicbrew ironicbrew changed the title Rebuilt /example Rebuilt /example fixes #940 Feb 12, 2023
@ironicbrew
Copy link
Author

IMG_0124 (1)

@marcosinigaglia
Copy link
Member

Thanks

@marcosinigaglia marcosinigaglia merged commit 261c56f into innoveit:master Feb 13, 2023
@marcosinigaglia marcosinigaglia linked an issue Jan 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants