-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Python 2.7 to Python 3.12 #330
Open
mundanevision20
wants to merge
21
commits into
idank:master
Choose a base branch
from
mundanevision20:mundanevision20-python3-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate from Python 2.7 to Python 3.12 #330
mundanevision20
wants to merge
21
commits into
idank:master
from
mundanevision20:mundanevision20-python3-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via "prefers-color-scheme". Fixes idank#236
…milar Signed-off-by: Страхиња Радић <[email protected]>
mundanevision20
force-pushed
the
mundanevision20-python3-migration
branch
from
September 21, 2024 10:44
86fa289
to
29a20e6
Compare
I also merged #237 by @rugk, #248 by @apoorvlathey and #293 by @Strahinja into this PR as the original PRs are apparently no longer active. Based on #232 by @wesinator I updated the references to use manpages of Ubuntu noble (24.04 LTS). Due to the high number of merge conflicts I decided to apply the changes without merging. |
Thanks for this work! I suggest to keep this PR focused on the python
migration and not pull in unrelated stuff like updating the man pages.
…On Sat, Sep 21, 2024, 13:51 Henning Weller ***@***.***> wrote:
I also merged #237 <#237> by
@rugk <https://github.com/rugk>, #248
<#248> by @apoorvlathey
<https://github.com/apoorvlathey> and #293
<#293> by @Strahinja
<https://github.com/Strahinja> into this PR as the original PRs are
apparently no longer active.
Based on #232 <#232> by
@wesinator <https://github.com/wesinator> I updated the references to use
manpages of Ubuntu noble (24.04 LTS). Due to the high number of merge
conflicts I decided to apply the changes without merging.
—
Reply to this email directly, view it on GitHub
<#330 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJX5RCJB7K2V7NGZTHM7IDZXVFU3AVCNFSM6AAAAABOTOTIV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGE2DEMJTG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I mainly adapted the Python code to work with Python 3.12 I also enhanced the formatting and logging to ease future maintenance.