Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brand Refoss In core_brands #6203

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ashionky
Copy link
Contributor

Proposed change

Add Brand Refoss in core_brands

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @ashionky 👋

Can you please link up the PR in our core repository that adds this brand?

Thanks! 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 11, 2024 08:45
@ashionky
Copy link
Contributor Author

ashionky commented Dec 11, 2024

Hi there @ashionky 👋

Can you please link up the PR in our core repository that adds this brand?

Thanks! 👍

../Frenck

Hi @frenck
My integration has been launched in the core repository,
I need to create a brand now, and the core integration will use this brand,

In the future, we will add a new integration that will use the same Refoss brand, similar to Xiaomi.
I don't know if my introduction is clear.

@ashionky ashionky requested a review from frenck December 11, 2024 09:12
@ashionky ashionky marked this pull request as ready for review December 11, 2024 09:18
@frenck
Copy link
Member

frenck commented Dec 11, 2024

My integration has been launched in the core repository,

Nice 👍

I need to create a brand now, and the core integration will use this brand,

Ok, so, again, can you point me to the PR that adds the brand to Home Assistant (please note, a brand and integration are not the same things in Home Assistant).

../Frenck

@frenck frenck marked this pull request as draft December 11, 2024 12:07
@ashionky
Copy link
Contributor Author

ashionky commented Dec 12, 2024

My integration has been launched in the core repository,

Nice 👍

I need to create a brand now, and the core integration will use this brand,

Ok, so, again, can you point me to the PR that adds the brand to Home Assistant (please note, a brand and integration are not the same things in Home Assistant).

../Frenck

This is the merged PR:
#4525

@ashionky ashionky marked this pull request as ready for review December 12, 2024 01:14
@ashionky ashionky marked this pull request as draft December 12, 2024 08:39
@ashionky ashionky marked this pull request as ready for review December 12, 2024 08:42
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the merged PR:
#4525

That is adding the branding assets. Please link the core PR that adds the branding in Home Assistant Core.

Please note (again) an integration != a brand in Home Assistant. A brand is a concept that can bundle multiple integration from a single brand in Core.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 12, 2024 19:37
@ashionky
Copy link
Contributor Author

This is the merged PR:
#4525

That is adding the branding assets. Please link the core PR that adds the branding in Home Assistant Core.

Please note (again) an integration != a brand in Home Assistant. A brand is a concept that can bundle multiple integration from a single brand in Core.

../Frenck

In the core, I found the brand. Does it require two integrations to set up the brand?

@frenck
Copy link
Member

frenck commented Dec 13, 2024

In the core, I found the brand.

I have not... hence me asking multiple times now to send me a link to the pull request that adds the brand to the core. Could you please provide me a link to a PR handling this?

Does it require two integrations to set up the brand?

There is no reason to add a layer to handle multiple integrations for a brand that has a single integration.

../Frenck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants