-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brand Refoss In core_brands #6203
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @ashionky 👋
Can you please link up the PR in our core repository that adds this brand?
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @frenck In the future, we will add a new integration that will use the same Refoss brand, similar to Xiaomi. |
Nice 👍
Ok, so, again, can you point me to the PR that adds the brand to Home Assistant (please note, a brand and integration are not the same things in Home Assistant). ../Frenck |
This is the merged PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the merged PR:
#4525
That is adding the branding assets. Please link the core PR that adds the branding in Home Assistant Core.
Please note (again) an integration != a brand in Home Assistant. A brand is a concept that can bundle multiple integration from a single brand in Core.
../Frenck
In the core, I found the brand. Does it require two integrations to set up the brand? |
I have not... hence me asking multiple times now to send me a link to the pull request that adds the brand to the core. Could you please provide me a link to a PR handling this?
There is no reason to add a layer to handle multiple integrations for a brand that has a single integration. ../Frenck |
Proposed change
Add Brand Refoss in core_brands
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)