Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letsencrypt: Bump certbot-dns-infomaniak to 0.2.3 #3860

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

notFloran
Copy link
Contributor

@notFloran notFloran commented Dec 11, 2024

Bump certbot-dns-infomaniak to 0.2.3 to fix the issue Infomaniak/certbot-dns-infomaniak#40

Summary by CodeRabbit

  • New Features
    • Updated the changelog to include a new version entry for 5.2.9.
  • Updates
    • Incremented the CERTBOT_DNS_INFOMANIAK_VERSION to 0.2.3.
    • Updated the version in the configuration file to 5.2.9.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @notFloran

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 11, 2024 08:04
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request include updates to the versioning of the Let's Encrypt project. The changelog has been modified to reflect the new version 5.2.9, which includes the update of the certbot-dns-infomaniak package to version 0.2.3. Additionally, the build.yaml file has been updated to increment the CERTBOT_DNS_INFOMANIAK_VERSION to 0.2.3, and the config.yaml file has had its version updated from 5.2.8 to 5.2.9. These modifications maintain the project's documentation and configuration in alignment with the latest changes.

Changes

File Change Summary
letsencrypt/CHANGELOG.md Added version entry for 5.2.9; updated certbot-dns-infomaniak to version 0.2.3.
letsencrypt/build.yaml Updated CERTBOT_DNS_INFOMANIAK_VERSION from 0.2.2 to 0.2.3.
letsencrypt/config.yaml Updated version from 5.2.8 to 5.2.9; no other structural changes made.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 324751d and 1cd049f.

📒 Files selected for processing (3)
  • letsencrypt/CHANGELOG.md (1 hunks)
  • letsencrypt/build.yaml (1 hunks)
  • letsencrypt/config.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • letsencrypt/CHANGELOG.md
  • letsencrypt/config.yaml
🧰 Additional context used
📓 Path-based instructions (1)
letsencrypt/build.yaml (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

🔇 Additional comments (1)
letsencrypt/build.yaml (1)

24-24: Version update looks good, verifying changelog and stability.

The version bump to 0.2.3 aligns with the PR objectives.

✅ Verification successful

Let me gather more information about the repository and releases to make a more informed decision.


Version 0.2.3 is verified as the latest stable release

The version bump to 0.2.3 is correct and verified:

  • Released on December 5th, 2024
  • Available on PyPI with matching version
  • Latest tag in the repository
  • Issue Add add-on duckDNS #40 is closed
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the version and changelog of certbot-dns-infomaniak

# Check PyPI for latest version info
curl -s https://pypi.org/pypi/certbot-dns-infomaniak/json | jq -r '.info | {version: .version, release_date: .release_date}'

# Check GitHub releases for changelog
gh api repos/infomaniak/certbot-dns-infomaniak/releases/tags/v0.2.3 --jq '.body'

# Verify if issue #40 is addressed
gh api repos/infomaniak/certbot-dns-infomaniak/issues/40 --jq '.state'

Length of output: 492


Script:

#!/bin/bash
# Check latest releases and tags
gh api repos/infomaniak/certbot-dns-infomaniak/releases --jq '.[0] | {tag_name, published_at, body}'

# Check tags directly
gh api repos/infomaniak/certbot-dns-infomaniak/tags --jq '.[0:3] | .[] | {name, commit}'

# Verify the package on PyPI
curl -s "https://pypi.org/pypi/certbot-dns-infomaniak/0.2.3/json" | jq -r '.urls[0] | {upload_time, url}'

Length of output: 1260


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @notFloran 👍

../Frenck

@frenck frenck merged commit cb3540e into home-assistant:master Dec 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants