Move Turbo closer to Large to avoid confusing it with Tiny #3857
Conversation
|
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes involve updates to the documentation and configuration of the Whisper add-on in Home Assistant. The documentation has been clarified regarding the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Whisper
participant Documentation
User->>Documentation: Requests information on models
Documentation-->>User: Provides model information
User->>Whisper: Configures model selection
Whisper-->>User: Acknowledges configuration
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
whisper/config.yaml (1)
22-22: Approve the reordering but suggest minor adjustmentThe reordering of models achieves the PR objective by moving 'turbo' away from 'tiny' to reduce confusion. The new position after the 'large' variants is logical since 'turbo' is faster than 'large-v3'.
Consider this minor adjustment to maintain better grouping:
- list(tiny-int8|tiny|tiny.en|base-int8|base|base.en|small-int8|distil-small.en|small|small.en|distil-medium.en|medium-int8|medium|medium.en|large|large-v1|distil-large-v2|large-v2|distil-large-v3|large-v3|turbo|custom) + list(tiny-int8|tiny|tiny.en|base-int8|base|base.en|small-int8|distil-small.en|small|small.en|distil-medium.en|medium-int8|medium|medium.en|large|large-v1|distil-large-v2|large-v2|distil-large-v3|large-v3|custom|turbo)This places 'custom' at the end as it's a special case, making the progression from specific models to custom more logical.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
whisper/DOCS.md(1 hunks)whisper/config.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- whisper/DOCS.md
🧰 Additional context used
📓 Path-based instructions (1)
whisper/config.yaml (6)
Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern */**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.
Pattern */**(html|markdown|md): do not comment on HTML used for icons
Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
There was a problem hiding this comment.
Thanks, @googanhiem 👍
Can you also update the changelog and version? Otherwise the update will not ship.
../Frenck
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@frenck updated the version number 👍 |
Move Turbo closer to Large to avoid confusing it with Tiny.
Summary by CodeRabbit
Documentation
turbomodel's performance compared tolarge-v3.Configuration
2.3.0to2.3.1.turboto the end of the list.Changelog
turbomodel's position in the list.