-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AuthAnnonymous() when connecting to DBus over TCP #796
base: develop
Are you sure you want to change the base?
Conversation
This seems like it could be a security hole. What is the use case? It seems like it would be better to run Bleak on the same machine as BlueZ and use some sort of RPC instead. |
Convenience during development. |
Absolutely, just not in Bleak. For this to be an thing you would first have to edit /etc/dbus-1/system-local.conf and /lib/systemd/system/dbus.socket on the host machine and re-define DBUS_SYSTEM_BUS_ADDRESS on your local machine. I would argue that if someone make these kind of changes and don't know better than to remain on an isolated LAN then bigger security holes are at stake. |
We recently made some similar changes in #1182, so if this is still needed, would like to add a |
bfcb1fd
to
7c3c0ef
Compare
Thanks for updating. I would rather use our own environment variable (e.g. Also, could you add a changelog entry? |
DBus-next defaults to using AuthExternal() when autenticating but this only works when we are working on the same machine. Tested on Ubuntu 21.10.
7c3c0ef
to
da26aba
Compare
DBus-next defaults to using AuthExternal() when autenticating but this only works when we are working on the same machine.
Tested on Ubuntu 21.10.