Dimensional counters #22
Conversation
Breaking change: the Sample type now holds dimensions as key-value pairs.
|
This change breaks consumers of the API, and maybe some old GHC/Base versions. (Built with I plan to wrap the new module with a type-fancy layer (either in this package or in another package) for a stronger guarantee that the dimensions passed to Minimal compatibility patches to demonstrate the feature are provided for
The example works and displays individual curves flattening the dimensions as follows. I'm more interested in providing support into |
|
@tibbe any comment about this MR? I'm willing to provide a typeful layer above this one to enforce more type-safety between the construction and consuming sides, though it should probably go in another package where we can allow stricter GHC versions. |
| type Point = [Text] | ||
|
|
||
| data Dimensional a = Dimensional { | ||
| _create :: !(IO a) |
There was a problem hiding this comment.
Please stick to the field naming pattern used for other data types (i.e. no leading underscore, but prefixed as needed).
| type Label = Dimensional Label.Label | ||
| type Distribution = Dimensional Distribution.Distribution | ||
|
|
||
| example :: IO () |
There was a problem hiding this comment.
This belongs in the examples/ directory and/or in some docs.
| import Data.HashMap.Strict (HashMap, empty) | ||
| import qualified Data.HashMap.Strict as HashMap | ||
|
|
||
| type Name = Text |
There was a problem hiding this comment.
Lots of Haddoc docs needed here.
| @@ -0,0 +1,88 @@ | |||
| {-# LANGUAGE LambdaCase #-} | |||
There was a problem hiding this comment.
This file needs some top-level Haddocks explaining how to use this module and what it's for.
|
Closing in favour of #32. |
|
Thanks @matth- |
No description provided.