-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UID register to protocol #39
base: main
Are you sure you want to change the base?
Add UID register to protocol #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good assuming it can be done without affecting R_DEVICE_NAME.
Use the address name |
This is now implemented on the RP2040 Harp Core: |
|
Summary
This PR adds a new register to the protocol called
UID
.Motivation
We currently use a single U16 value to keep track of the serial numbers of devices. This is a rather small number and hardly future proof. Adhering on a pre-existing standard would make the implementation much more generic. For instance, it would allow one to co-opt pico's chip serial number (64bit) into this register.
Detailed Design
For the sake of backward compatibility, we will add a new register instead of modifying the current
R_Serial_Number
.A new register will be added with the following specs:
Name: UID
Address: 16
Format: U8[16]
Access: Read-only
A deprecation warning was also added to the protocol regarding register
R_SERIAL_NUMBER
. For now, this register will duplicate the first two bytes ofR_UID
. On the next major release, theR_SERIAL_NUMBER
will likely be removed and onlyR_UID
supported.Design Meetings
See further discussion in the following issues: