v3.0 firmware release #20
Conversation
This is needed to keep the firmware update working.
| Pulse10MsWhenStop: {value: 7, description: High when sound stops during 10 ms. } | ||
| Pulse100MsWhenStop: {value: 8, description: High when sound starts during 100 ms. } | ||
| PulseForSoundStartOrFrequencyChange: {value: 1, description: Positive pulse when sound starts or frequency changes. } | ||
| DataStreamConfiguration: |
There was a problem hiding this comment.
Consider changing to DataStreamDispatchRate and DataStreamDispatchRateConfig
There was a problem hiding this comment.
I guess both could work, my question here would be whether this enum would store only specifically data stream rates, or possibly other flags. I guess maybe only rates since it is a group mask.
Bug correction fw clean registers
There was a problem hiding this comment.
Minor comments, otherwise looks good. The PR is still marked as draft, I guess one important thing we need to discuss before broad deployment is how to deal with firmware updates in cases of multi-microcontroller devices.
Would be nice if it is possible to have a uniform update procedure using the existing bootloader protocol, but maybe let us discuss this in a separate issue / PR.
There was a problem hiding this comment.
Is there an alternative to the registers.xls file?
| Pulse10MsWhenStop: {value: 7, description: High when sound stops during 10 ms. } | ||
| Pulse100MsWhenStop: {value: 8, description: High when sound starts during 100 ms. } | ||
| PulseForSoundStartOrFrequencyChange: {value: 1, description: Positive pulse when sound starts or frequency changes. } | ||
| DataStreamConfiguration: |
There was a problem hiding this comment.
I guess both could work, my question here would be whether this enum would store only specifically data stream rates, or possibly other flags. I guess maybe only rates since it is a group mask.
No description provided.