Add toGeoJson() #149
Open
Add toGeoJson() #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for this great package!
As suggested in #113 , it's not yet possible to generate normalized GeoJSON for a geometry. This PR adds this functionality including an updated README and tests. Properties in GeoJSON are also supported.
Contrary to
Geometry::toJson(), the newGeometry::toGeoJson()returns a string instead of a JSON-able representation. I'm not sure if this is a good idea (becausetoGeoJsonimplies it should return JSON) or if it should behave liketoJson()(for consistency). What do you think?Let me know if you'd like me to make any changes!
Closes #113