Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DTA's authorization header #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artplan1
Copy link
Contributor

@artplan1 artplan1 commented Aug 8, 2022

Authorization header support was implemented in lynndylanhurley/devise_token_auth#1534

This works in edge DTA, but seems like can't be merged until graphql_devise and DTA are properly synced

@00dav00
Copy link
Contributor

00dav00 commented Aug 9, 2022

Hi @artplan1 this is an interesting addition!
I think we need to think about backward compatibility since this header is not going to be present in all DTA versions.

Also, adding/editing some specs to tests the new header is working as expected would be handy here:

  • new header being returned on login
  • new header being used to authenticate
  • new header cleaned up/invalidated correctly on logout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants