Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Dart imports #8380

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

insertjokehere
Copy link
Contributor

Fixes #7609
Fixes #8379

This PR builds on the work from #8259 to:

  • Add a simple test to catch regressions in this area
  • Fix an issue where include chains (a includes b which includes c) are naively represented as a single import in Dart, which doesn't reflect how Dart handles imports. I've adjusted the Dart code generator to include an export statement to match import statements for files in the same namespace to ensure that include chains work in the generated code

@github-actions github-actions bot added c++ codegen Involving generating code from schema dart labels Aug 20, 2024
@fawdlstty
Copy link

@CasperN @vaind Sorry to tag you out of the blue. This part of the modification is very important to me. Can you promote the merger of PR?

@vaind
Copy link
Contributor

vaind commented Nov 15, 2024

I'm not a maintainer so I don't have merge permissions

@fawdlstty
Copy link

@aardappel Sorry to tag you out of the blue. Can you promote the merger of PR?

aardappel
aardappel previously approved these changes Nov 18, 2024
@aardappel
Copy link
Collaborator

This was merged: #8313

Can you rebase this one, seems there may be some conflicts.

@aardappel
Copy link
Collaborator

There also seem to be dart codegen changes to the generated files that are not included in this PR

@insertjokehere
Copy link
Contributor Author

@aardappel thanks for the review - I've rebased and updated the generated bindings. Happy to squash this down before merge.

@aardappel aardappel enabled auto-merge (squash) November 18, 2024 21:42
@aardappel
Copy link
Collaborator

There also seem to be dart codegen changes to the generated files that are not included in this PR

This still seems to be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema dart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dart, master] Recursive imports are not respected Dart: missing import in generated file
4 participants