Fix repository category update #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
fix_category_update
branch
from
28b0897
to
66c6acd
Compare
`category_ids[]` is not a valid agument for the update endpoint (it is for create). To fix this I just call into bioblend instead of using the custom put request. Fixes galaxyproject#1480
mvdbeek
force-pushed
the
fix_category_update
branch
from
66c6acd
to
d273345
Compare
|
Thanks @mvdbeek! |
nsoranzo
approved these changes
Oct 28, 2024
|
The shellescape errors will be fixed by galaxy-tool-util 24.1.3, which is currently only on test PyPI. |
|
I've promoted the pre-release to release and the packages are on pypi now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
category_ids[]is not a valid agument for the update endpoint (it is for create). To fix this I just call into bioblend instead of using the custom put request. Fixes #1480