Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] hash.tsv new format plus linting and auto-adding hashes #15640

Closed
wants to merge 13 commits into from

Conversation

fabianegli
Copy link

The hash.tsv already contains a list of all the mulled containers, but it does not include their hashes. It would be very convenient if it did, because then the helper tools like the one here would not have to re-calculate them.

This PR is intended to solve the following issues:

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.1 milestone Feb 23, 2023
@fabianegli fabianegli changed the title hash.tsv new format plus linting and auto-adding hashes [WIP] hash.tsv new format plus linting and auto-adding hashes Feb 24, 2023
@fabianegli
Copy link
Author

Hey - I can't test all the code I am going to change locally and this basically preventing me from iterating fast. And the workflow approval is slow. It would tremendously help to have faster feedback cycles from tests.

@nsoranzo
Copy link
Member

nsoranzo commented Mar 2, 2023

And the workflow approval is slow. It would tremendously help to have faster feedback cycles from tests.

The workflow approval is a GitHub feature for first-time contributors to any repository, so this manual approval will only be necessary until your first PR is merged.

@mvdbeek
Copy link
Member

mvdbeek commented Mar 3, 2023

Do you want to maybe focus on the core of the issue you want to solve ? So far we have no idea where you're going with this. Also you can enable the tests in your fork.

@fabianegli
Copy link
Author

Want to - yes. Waiting for some clarification in BioContainers/multi-package-containers#2521 to know what would be most welcome/desired.

@fabianegli

This comment was marked as outdated.

@nsoranzo
Copy link
Member

Please use make format to fix these issues.

@mvdbeek mvdbeek modified the milestones: 23.1, 23.2 Jun 21, 2023
@fabianegli
Copy link
Author

Closing, because my branch is dead.

@fabianegli fabianegli closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants