Read repos from pom #28
Conversation
Anderssorby
force-pushed
the
read-repos-from-pom
branch
from
f3f4133 to
99864d6
Compare
|
Sorry I haven't reviewed this yet; it's on my radar. |
Anderssorby
force-pushed
the
read-repos-from-pom
branch
from
f3f1bd7 to
9a7ecc1
Compare
There was a problem hiding this comment.
I like the contribution -- sorry for getting back to late but I think it needs improvement.
- I suspect many put repositories in settings.xml which can be read via a Maven library
- There is better libraries to read pom.xml native to Maven
👍 thank you for the contribution so far!
| public static ImmutableList<URL> getRepositoriesFromPom(Document doc) throws XPathException, MalformedURLException { | ||
|
|
||
| XPath xPath = XPathFactory.newInstance().newXPath(); | ||
| String expression = "/project/repositories/repository"; | ||
|
|
||
| NodeList repositories = (NodeList) xPath.compile(expression).evaluate(doc, XPathConstants.NODESET); | ||
| LOGGER.debug("Found {} repositories in pom.xml", repositories.getLength()); |
There was a problem hiding this comment.
There are maven libraries for parsing the pom file.
I think they should be used instead ?
We also want to parse the ~/.m2/settings.xml file on the users machine.
ModelBuildingRequest req = new DefaultModelBuildingRequest();
req.setProcessPlugins( false );
req.setPomFile( file );
req.setModelResolver( new RepositoryModelResolver( basedir, pathTranslator ) );
req.setValidationLevel( ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL );
Model model;
try
{
model = builder.build( req ).getEffectiveModel();
}
catch ( ModelBuildingException e )
{
...
}
There was a problem hiding this comment.
Yes, that would be better. I don't have a lot of time to work on this anymore however.
There was a problem hiding this comment.
No worries; thank you for trying the contribution.
We can keep it open if others want to try and continue it or just close it then for now?
I'm also a bit swamped this quarter so I likely won't be able to make the addition myself.
Now it parses the pom.xml and extracts the repositories. Probably there are improvements that can be made.