Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add windows-specific installers for some tools #253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add windows-specific installers for some tools #253

wants to merge 3 commits into from

Conversation

TobiTenno
Copy link
Contributor

@TobiTenno TobiTenno commented Jul 21, 2024 •
edited
Loading

  • add support for some additional windows tools
  • add development (manual) configuration for printing stack traces to avoid excess output
  • add user interaction to press enter/return after:
    • invalid command
    • successful command
  • allow calling any "subcommand" from any of the category, or using existing categories to call commands
  • modularize uninstall to uninstall cleanly with tools that support it
  • add verbose console interface

@TobiTenno TobiTenno force-pushed the windows-installs branch 3 times, most recently from 62f4de0 to d1793a1 Compare July 21, 2024 01:41
thehappydinoa
thehappydinoa requested changes Jul 21, 2024
View reviewed changes
fsociety/__main__.py Outdated Show resolved Hide resolved
fsociety/core/repo.py Outdated Show resolved Hide resolved
mypy.ini Outdated Show resolved Hide resolved
fsociety/web_apps/cli.py Outdated Show resolved Hide resolved
fsociety/core/repo.py Outdated Show resolved Hide resolved
fsociety/core/repo.py Outdated Show resolved Hide resolved
fsociety/core/menu.py Outdated Show resolved Hide resolved
fsociety/core/errors.py Outdated Show resolved Hide resolved
fsociety/core/config.py Outdated Show resolved Hide resolved
@TobiTenno TobiTenno force-pushed the windows-installs branch 2 times, most recently from 4672219 to 9b62a2f Compare July 21, 2024 16:54
@TobiTenno TobiTenno requested a review from thehappydinoa July 21, 2024 23:55
@TobiTenno
Copy link
Contributor Author

@thehappydinoa any other thoughts? what do you think of the new console interface? too complicated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehappydinoa thehappydinoa Awaiting requested review from thehappydinoa

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiTenno @thehappydinoa