-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
127 compare header and schema #146
Draft
PietrH
wants to merge
17
commits into
main
Choose a base branch
from
127-compare-header-and-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# create package with the wrong case in the schema of observations
wrong_case_in_schema_pkg <- example_package
## change case
purrr::pluck(wrong_case_in_schema_pkg, "resources", 2, "schema", "fields") <-
purrr::chuck(wrong_case_in_schema_pkg, "resources", 2, "schema", "fields") %>%
purrr::map2_chr(
c(TRUE, TRUE, FALSE, FALSE, FALSE, TRUE, TRUE), #set some to upper, some to lower case
~ ifelse(.y,
toupper(purrr::chuck(.x, "name")),
tolower(purrr::chuck(.x, "name"))
)
)
read_resource(wrong_case_in_schema_pkg, "observations") Fails on: frictionless-r/R/check_schema.R Lines 19 to 20 in 7dba18d
Error in `purrr::map_chr()` at frictionless-r/R/check_schema.R:20:2:
ℹ In index: 1.
Caused by error in `.x$name`:
! $ operator is invalid for atomic vectors
Run `rlang::last_trace()` to see where the error occurred. |
test for output class instead of no_error because no_error artificially increases test coverage, and is experimental. expect_s3_class() will fail on any error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.