Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Add die() typedoc #3985

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

JS: Add die() typedoc #3985

wants to merge 2 commits into from
+7 −0

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Nov 3, 2024

What's new

  • Added die() to global typedoc since it was missing
  • Not sure if it should be 0.1 or count as a bump to 0.2 already... technically this was always available, just not documented... IMO it should still count as SDK 0.1 and go up as a semver "patch" increase of the npm module (0.1.2)

Verification

  • Observe, the typedocs now magically contain the die() function definition

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Willy-JL