New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am own the JS #3982

Open

portasynthinca3 wants to merge 3 commits into dev from portasynthinca3/i-am-own-the-js

+8 −7

Member

portasynthinca3 commented Nov 1, 2024

What's new

Fix tsconfig.json in JS project template
Make me a co-owner of the JS subsystem
Remove drunkbatya from CODEOWNERS since he left the company

Verification

Create and run a project as per the instructions in create-fz-app using npm (pnpm had no issues prior to this PR)

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix

portasynthinca3 added 3 commits

November 1, 2024 17:36


          fix: js app template

2cf425d


          i am own the js

a5789ac


          farewell

e6976b4

portasynthinca3 requested review from skotopes, DrZlo13, hedger, gsurkov and nminaylov as code owners

November 1, 2024 14:45

github-actions bot commented Nov 1, 2024

Compiled f7 firmware for commit e6976b4f:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skotopes Awaiting requested review from skotopes skotopes is a code owner

DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

hedger Awaiting requested review from hedger hedger is a code owner

gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet