Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to change the display brightness from the Lock Menu #3850

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Added the ability to change the display brightness from the Lock Menu #3850

wants to merge 10 commits into from
+344 −71

Conversation

janwiesemann
Copy link
Contributor

What's new

  • Added scroll support for the Lock Menu
  • Added the ability to change the display brightness from the Lock menu
  • Changed the existing Lock Menu code to support easier expansion

Screenshot-20240821-170414
Screenshot-20240821-170432
Screenshot-20240821-170441

Verification

  • Opened the Lock Menu and scrolled around
  • Changed some values of the new and old features
  • Restarted the device to validate if the settings have been saved correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the UI Affects UI label Aug 24, 2024
@janwiesemann
Copy link
Contributor Author

@hedger I've fixed the formatting issues

@skotopes
Copy link
Member

skotopes commented Sep 7, 2024

I'll forward this to our art team, meanwhile there are couple things I've highlighted in review.

Un-draft when ready.

@skotopes skotopes marked this pull request as draft September 7, 2024 14:35
@janwiesemann janwiesemann marked this pull request as ready for review September 7, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janwiesemann @skotopes @hedger