New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3614] More reliable MFC tests #3816

Draft

Astrrra wants to merge 2 commits into doom/2991-e2e-runner from astra/3614-failsafe-mfc-tests

+2,174 −2,239

Member

Astrrra commented Jul 31, 2024

What's new

MFC emulation tests are now way more resilient to communication errors and shouldn't fail because of them now.

Verification

Run the tests as usual, check that the intermittent failures no longer occur

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix

Astrrra added 2 commits

July 31, 2024 18:35


          Rework test execution logic for better reliability

7b0771c


          Fix skipping logic

dd4f1ef

Astrrra changed the base branch from dev to doom/2991-e2e-runner

July 31, 2024 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skotopes Awaiting requested review from skotopes skotopes will be requested when the pull request is marked ready for review skotopes is a code owner

DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 will be requested when the pull request is marked ready for review DrZlo13 is a code owner

hedger Awaiting requested review from hedger hedger will be requested when the pull request is marked ready for review hedger is a code owner

Labels

None yet