-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui: Submenu and VarItemList API additions and improvements #3621
Draft
Willy-JL
wants to merge
12
commits into
flipperdevices:dev
Choose a base branch
from
Willy-JL:submenu-varitemlist-api
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+541
−41
Commits on Apr 30, 2024
-
Gui: Submenu and VarItemList API additions and improvements
API additions: - `submenu_add_lockable_item()`: based on flipperdevices#2289 which was rejected, CFWs merged it and improved it over time, theres a few apps that use it by now (example usecase: highlighting that some features are not available in current configuration / state) - `submenu_set_orientation()`: can have vertical submenu (user's preference for ux, same concept works great in infrared app, could be reused there to make more of the app vertical instead of having to keep switching) - `variable_item_list_get()`: get and allow editing an item after creation (example usecase: editing one option changes state of other entries in the list, like if they are locked due to incompatible settings or if they have different labels or values) - `variable_item_list_set_header()`: feature parity with `submenu` widget (example usecase: headers are pretty but want editable options not just a list) - `variable_item_set_item_label()`: allow changing label after adding item (example usecase: want to show index of item, can have value shown and put (1/10) in label dynamically, also probably more, allows more creativity) - `variable_item_set_locked()`: same as above for `submenu`, based on same code but ported to varitemlist by me. also allows setting locked state after the fact, remembers locked message so after creation you can toggle with `set_locked(item, false/true, NULL)` (example usecase, some settings combinations in this screen are incompatible, like GPIO pins overlapping when configuring) General improvements: - Can have header in Variable Item List - Can have a vertical Submenu - Can lock items in Variable Item List and Submenu - Variable Item List label and value scroll if too long - Variable Item List value arrows shrink if value is < 4 characters - More freedom and usefulness in Variable Item List API - Cleaned up some parts of the code and some magic numbers are now defined Acknowlegments: - Original submenu lockable items code by @giacomoferretti in flipperdevices#2289 - Vertical submenu and some code improvements by Unleashed CFW team - Most other edits by me @Willy-JL - Hope I'm not forgetting someone else that was involved
Configuration menu - View commit details
-
Copy full SHA for 6fe017a - Browse repository at this point
Copy the full SHA 6fe017aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a1a539 - Browse repository at this point
Copy the full SHA 3a1a539View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 20cb434 - Browse repository at this point
Copy the full SHA 20cb434View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba8b8e3 - Browse repository at this point
Copy the full SHA ba8b8e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for add64ef - Browse repository at this point
Copy the full SHA add64efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3237c24 - Browse repository at this point
Copy the full SHA 3237c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942f78a - Browse repository at this point
Copy the full SHA 942f78aView commit details
Commits on May 15, 2024
-
Merge branch 'dev' of https://github.com/flipperdevices/flipperzero-f…
…irmware into submenu-varitemlist-api
Configuration menu - View commit details
-
Copy full SHA for d0c4d0c - Browse repository at this point
Copy the full SHA d0c4d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fadef34 - Browse repository at this point
Copy the full SHA fadef34View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5624c5f - Browse repository at this point
Copy the full SHA 5624c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 974cd38 - Browse repository at this point
Copy the full SHA 974cd38View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b88828 - Browse repository at this point
Copy the full SHA 1b88828View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.