[feldera] first commit: add preliminary support #1
Conversation
Signed-off-by: Abhinav Gyawali <[email protected]>
Signed-off-by: Abhinav Gyawali <[email protected]>
Signed-off-by: Abhinav Gyawali <[email protected]>
Signed-off-by: Abhinav Gyawali <[email protected]>
Signed-off-by: Abhinav Gyawali <[email protected]>
abhizer
force-pushed
the
feldera
branch
2 times, most recently
from
cb2e78e to
564035c
Compare
* also use the blackbox method for non optimizing query in NoREC Signed-off-by: Abhinav Gyawali <[email protected]>
| implements FelderaExpression { | ||
|
|
||
| public enum FelderaUnaryPostfixOperator implements BinaryOperatorNode.Operator { | ||
| IS_NULL("IS NULL"), IS_NOT_NULL("IS NOT NULL"), IS_FALSE("IS FALSE"), IS_NOT_TRUE("IS NOT TRUE"), |
There was a problem hiding this comment.
In general this doesn't adhere to our java style guidelines (which are unspecified).
But for enums I think these should really be one per line.
There was a problem hiding this comment.
I think it is the mvn formatter that puts them all together in one line.
| return expr; | ||
| } | ||
|
|
||
| public String getStringRepresentation() { |
There was a problem hiding this comment.
Frankly I think that CAST(e AS type) is more robust.
This syntax is Postgres specific.
But who knows, maybe it will just work?
There was a problem hiding this comment.
I found that this works, and is easier to read. But we can switch to CAST(e AS type) if you want.
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| public class FelderaClient { |
There was a problem hiding this comment.
this file may be useful as an alternative SDK for interacting with Feldera, in addition to the Python one.
There was a problem hiding this comment.
Yeah, but this no where as close to being as good as the python one. It might be worth investing some time to improve this.
| } | ||
|
|
||
| private FelderaExpression generateStringExpression(int depth) { | ||
| // TODO |
There was a problem hiding this comment.
in general any of these can have a call to a function with a suitable return type.
There was a problem hiding this comment.
Yes, this is a todo.
No description provided.