Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ocaml includes for flow-parser-bin #7443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lxe
Copy link

@lxe lxe commented Feb 4, 2019

flow-parser-bin requires opam and ocaml static libs to be installed, from what I gather. Maybe it requires a dynamic lib instead, but I was unable to find it for osx. Suggestions welcome!

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nmote
Copy link
Contributor

nmote commented Feb 5, 2019

I think @mroch is the most familiar with this

@mroch
Copy link
Contributor

mroch commented Feb 5, 2019

nice, thanks. how did you run into this? wondering why it built for me and on circle without these changes.

@vicapow
Copy link
Contributor

vicapow commented Feb 6, 2019

@mroch we just built it on os x. Not sure if I'm talking nonsense but maybe it's setup for you on your workstations automatically as an available dynamically linked lib?

@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants